[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 06/12] qemu: Refactor qemuBuildNetworkDriveURI to take a virStorageSourcePtr




On 11/12/2014 08:47 AM, Peter Krempa wrote:
> Instead of spliting out various fields, pass the complete structure and

s/spliting/splitting

> let the function pick various things of it.
> 
> As one of the callers isn't using virStorageSourcePtr to store the data,
> this patch adds glue code that fills the data into a dummy
> virStorageSourcePtr before calling the func.
> 
> This change will help when adding new fields that need output processing
> in the future.
> ---
>  src/qemu/qemu_command.c | 129 +++++++++++++++++++++++-------------------------
>  1 file changed, 62 insertions(+), 67 deletions(-)
> 

ACK

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]