[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 02/11] conf: Annotate source enums for character device struct members



On Wed, Nov 19, 2014 at 11:23:15 +0100, Peter Krempa wrote:
> Add a comment to track which values may be present in certain members of
> a struct _virDomainChrDef.
> ---
>  src/conf/domain_conf.h | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
> index 530a3ca..574d3ea 100644
> --- a/src/conf/domain_conf.h
> +++ b/src/conf/domain_conf.h
> @@ -1100,10 +1100,13 @@ struct _virDomainChrSourceDef {
> 
>  /* A complete character device, both host and domain views.  */
>  struct _virDomainChrDef {
> -    int deviceType;
> +    int deviceType; /* enum virDomainChrDeviceType */
> 
>      bool targetTypeAttr;
> -    int targetType;
> +    int targetType; /* enum virDomainChrConsoleTargetType ||
> +                       enum virDomainChrChannelTargetType ||
> +                       enum virDomainChrSerialTargetType according to deviceType */
> +
>      union {
>          int port; /* parallel, serial, console */
>          virSocketAddrPtr addr; /* guestfwd */

ACK

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]