[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] virdbus: don't force users to pass int for bool values



On 11/20/2014 08:12 AM, Conrad Meyer wrote:
> Hi Eric,
> 
> I think this change breaks build on FreeBSD:
> 
>   CC       util/libvirt_util_la-virdbus.lo
> util/virdbus.c:956:13: error: cast from 'bool *' to 'dbus_bool_t *' (aka 'unsigned int *') increases required alignment from 1 to 4 [-Werror,-Wcast-align]
>             GET_NEXT_VAL(dbus_bool_t, bool_val, bool, "%d");
>             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> util/virdbus.c:858:17: note: expanded from macro 'GET_NEXT_VAL'
>             x = (dbustype *)(*xptrptr + (*narrayptr - 1));              \
>                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated.

Valid complaint, so I'll have to figure something out to avoid it.  :(
Thanks for the heads up.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]