[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 00/12] Unbreak vm's backed by RBD disks



On 11/20/14 16:17, John Ferlan wrote:
> 
> 
> On 11/12/2014 08:47 AM, Peter Krempa wrote:
>> After recent refactors, starting a VM whose disk is backed by RBD storage would
>> fail as the parser for the backing file specification string was not
>> implemented in the metadata crawler.
>>
>> Reuse qemu's parser to do this and fix a few things around.
>>
>>
> 
> In general ACK series - although I did make comments to specific patches
> - some for simple typos/nits and a couple for minor adjustments which
> should be addressable without the need for a v2 (patch 5, 8, 9, 11, & 12).

Thanks. I've addressed most of the comments directly and I'll follow up
with a cleanup of some pre-existing issues as individually stated.

The series is now pushed.

> 
> Nice to know about virstoragetest.c - I can see the need to add perhaps
> some iscsi options there (learned something new today)

Tests are always welcome :)

> 
> 
> John
>>

Peter


Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]