[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 1/5] qemu: chardev: Extract more information about character devices



On Fri, Nov 21, 2014 at 16:29:51 +0100, Peter Krempa wrote:
> Improve the monitor function to also retrieve the guest state of
> character device (if provided) so that we can refresh the state of
> virtio-serial channels and perhaps react to changes in the state in
> future patches.
> 
> This patch changes the returned data from qemuMonitorGetChardevInfo to
> return a structure containing the pty path and the state for all the
> character devices.
> 
> The change to the testsuite makes sure that the data is parsed
> correctly.
> ---
> 
> Notes:
>     Version 2:
>     - all devices are now stored in the hash
>     - code is optimized according to the review
>     - example input code format enhanced to contain new field
>     - tests modified to pass
> 
>  src/qemu/qemu_monitor.c      | 13 ++++++++++-
>  src/qemu/qemu_monitor.h      |  6 ++++++
>  src/qemu/qemu_monitor_json.c | 51 +++++++++++++++++++++++++++++---------------
>  src/qemu/qemu_monitor_text.c | 17 ++++++++++-----
>  src/qemu/qemu_process.c      |  8 +++----
>  tests/qemumonitorjsontest.c  | 41 +++++++++++++++++++++++++++++------
>  6 files changed, 103 insertions(+), 33 deletions(-)

ACK

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]