[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 3/5] event: Add guest agent lifecycle event



On Mon, Nov 24, 2014 at 11:33:56 +0100, Jiri Denemark wrote:
> On Fri, Nov 21, 2014 at 16:29:53 +0100, Peter Krempa wrote:
> > As qemu is now able to notify us about change of the channel state used
> > for communication with the guest agent we now can more precisely track
> > the state of the guest agent.
> > 
> > To allow notifying management apps this patch implements a new event
> > that will be triggered on changes of the guest agent state.
> > ---
> > 
> > Notes:
> >     Version 2:
> >     - add more reasons
> >     - tweak enum and enum member names
> > 
> >  daemon/remote.c                  | 36 +++++++++++++++++++
> >  include/libvirt/libvirt-domain.h | 41 +++++++++++++++++++++
> >  src/conf/domain_event.c          | 78 ++++++++++++++++++++++++++++++++++++++++
> >  src/conf/domain_event.h          |  9 +++++
> >  src/libvirt_private.syms         |  2 ++
> >  src/remote/remote_driver.c       | 31 ++++++++++++++++
> >  src/remote/remote_protocol.x     | 16 ++++++++-
> >  src/remote_protocol-structs      |  7 ++++
> >  tools/virsh-domain.c             | 39 ++++++++++++++++++++
> >  9 files changed, 258 insertions(+), 1 deletion(-)
> 
> ACK, although I think we should try to generate more event handling
> code.

Actually, after seeing 5/5, I think
VIR_CONNECT_DOMAIN_EVENT_AGENT_LIFECYCLE_REASON_DOMAIN_BOOTED reason
should be renamed as
VIR_CONNECT_DOMAIN_EVENT_AGENT_LIFECYCLE_REASON_DOMAIN_STARTED because
it's really emitted when a domain starts rather than with the guest OS
inside boots.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]