[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] dbus: fix arrays of bools



On 11/21/2014 05:12 PM, Eric Blake wrote:
> Commit 2aa167ca tried to fix the DBus interaction code to allow
> callers to use native types instead of 4-byte bools.  But in
> fixing the issue, I missed the case of an arrayref; Conrad Meyer
> shows the following valid complaint issued by clang:
> 

> 
> * src/util/virdbus.c (GET_NEXT_VAL): Also fix array cases.
> (SET_NEXT_VAL): Fix uses of sub-int arrays.
> * tests/virdbustest.c (testMessageArray, testMessageArrayRef):
> Test it.
> 

Now pushed, after Conrad's off-list review and Ian's on-list review in a
different thread.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]