[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [python PATCH] event: Add bindings for agent lifecycle event



On 11/24/2014 08:42 AM, Peter Krempa wrote:
> Also add the example.
> ---
>  examples/event-test.py | 13 +++++++++++
>  libvirt-override.c     | 60 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 73 insertions(+)
>  mode change 100644 => 100755 examples/event-test.py
> 
> +++ b/libvirt-override.c
> @@ -6566,6 +6566,61 @@ libvirt_virConnectDomainEventTunableCallback(virConnectPtr conn ATTRIBUTE_UNUSED
>  }
>  #endif /* LIBVIR_CHECK_VERSION(1, 2, 9) */
> 
> +#if LIBVIR_CHECK_VERSION(1, 2, 11)

Not a problem with this patch, but at some point, we ought to revisit
these #if checks to instead gate them on whether libvirt.h provided a
given callback id (since it is possible to backport events to earlier
libvirt builds without breaking .so compatibility in downstream distros,
and those distors right now have to tweak these defines to match up with
their backports instead of having it happen automatically).  It's on my
todo list of something to experiment with when I get time.

ACK; it matches the patterns used in other events.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]