[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Revert "ip link needs 'name' in 3.16 to create the veth pair"



On 11/26/2014 01:33 AM, Martin Kletzander wrote:
> This reverts commit 433b427ff853ab72d32573d415e6ec569b77c7cb.
> 
> The patch was added in order to overcome a bug in iproute2 and since it
> was properly identified as a bug, particularly in openSUSE 13.2, and it
> is being worked on [1], the best solution for libvirt seems to be to
> keep the old behaviour.
> 
> [1] https://bugzilla.novell.com/show_bug.cgi?id=907093
> ---
>  src/util/virnetdevveth.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

I'm 50:50 on this one.  The workaround case is arguably more legible,
and is understood by all versions of iproute2 (including the buggy SUSE
release), so it's not like it is that ugly of a workaround.  The revert
is clean if you want to do it, but I don't see any compelling reason
requiring us to revert.  Maybe someone else can swing the vote.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]