[libvirt] [PATCH] vbox: remove unused code that causes build failures

[Martin Kletzander]

On Fri, Oct 03, 2014 at 08:50:47PM +0200, Martin Kletzander wrote:
>Since 87dea4fcffb2d1b120e7841adc0e3d8ea97ed777 vboxGetDrivers() is not
>used for getting the vbox network driver.  The only call the code does
>is using NULL as the @networkDriver_ret param , but the code still used
>vbox[0-9][0-9]NetworkDriver that didn't exist anymore.
>
>Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>---

I didn't do 'format-patch' and 'send-email' doesn't add notes.  So I'm
attaching them now:

I'm not pushing this as a build-breaker because I sense there might be
more to this.  The thing is that it doesn't fail for anyone else I
talked to, neither does it fail for out test suite.

I don't quite understand how it could worked (ever), since the only
definition of vbox22NetworkDriver (and others) was extern throughout
the whole git history.  I'm running autogen using --with-vbox even
though I don't have any virtualbox libraries/binaries installed, but
there is no such requirement for compiling the code.  And I don't
think the libraries would export a virNetworkDriver data struct
either.

Anyway, feel free to let me know where the real problem is and I'll be
glad to help with that either.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141003/9d279ad4/attachment-0001.sig>