[libvirt] [PATCHv2 1/2] util: Functions to update host network device's multicast filter

[Eric Blake]

[meta-comment]

On 10/10/2014 11:55 AM, akrowiak at linux.vnet.ibm.com wrote:
> From: Tony Krowiak <akrowiak at linux.vnet.ibm.com>
> 
> This patch provides the utility functions to needed to synchronize the
> changes made to a guest domain network device's multicast filter
> with the corresponding macvtap device's filter on the host:
> 
> * Get/add/remove multicast MAC addresses
> * Get the macvtap device's RX filter list
> 

The next paragraph:

> changes from v1:
> * Using virHexToBin function to parse HEX MAC address instead of
>   sscanf in virMacAddrParseHex function
> * Using ENOSYS in error messages for empty functions
> * Reading entire file with virFileReadAll function when
>   parsing /proc/net/dev_mcast file
> * Using VIR_APPEND_ELEMENT macro when appending array of
>   /proc/net/dev_mcast file objects
> * Misc. formatting changes
> 
> Signed-off-by: Tony Krowiak <akrowiak at linux.vnet.ibm.com>
> ---

belongs better here, after the ---.  Sending patch revision history is
GOOD - it tells reviewers what to look for.  But it is a comment to the
email, and not something intended for inclusion in the actual
libvirt.git (a year from now, we won't care that it was version 2 or
even version 10 committed, or what earlier versions looked like; we only
care about the commit that was actually accepted).

>  src/libvirt_private.syms |    4 +
>  src/util/virmacaddr.c    |   25 ++++
>  src/util/virmacaddr.h    |    4 +
>  src/util/virnetdev.c     |  358 ++++++++++++++++++++++++++++++++++++++++++++++
>  src/util/virnetdev.h     |   10 ++
>  5 files changed, 401 insertions(+), 0 deletions(-)
> 
>

I'll let Laine do the actual code review...


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 539 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141010/16f8dff2/attachment-0001.sig>