[libvirt] [PATCHv5 4/6] bhyvexml2argv: Add tests for domain-configured bootloader, args

[Daniel P. Berrange]

On Tue, Oct 28, 2014 at 11:16:52AM -0400, Conrad Meyer wrote:
> On Tue, Oct 28, 2014 at 10:55 AM, Daniel P. Berrange
> <berrange at redhat.com> wrote:
> > On Mon, Oct 27, 2014 at 10:37:39AM -0400, Conrad Meyer wrote:
> >> diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-disk-cdrom-grub.ldargs b/tests/bhyvexml2argvdata/bhyvexml2argv-disk-cdrom-grub.ldargs
> >> new file mode 100644
> >> index 0000000..d9161ba
> >> --- /dev/null
> >> +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-disk-cdrom-grub.ldargs
> >> @@ -0,0 +1,2 @@
> >> +/usr/local/sbin/grub-bhyve --root cd --device-map '<device.map>' --memory 214 \
> >> +bhyve
> >
> > Ah ha, I thought my command about device.map would become relevant :-)
> >
> > We probably want a 3rd expected data file  '.devmap' containing the
> > expected device map contents to compare against.
> 
> This can be done, sure. (IMO GRUB only needs to know about the boot
> device, be it CD or HDD, so this configuration will never be very
> exciting / surprising.)

If it is tiny, then you could also just avoid the extrenal .devmap
file and do a plain STREQ() in the bhyvexml2argvtest.c file in the
relevant place.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|