[libvirt] [PATCH v3 0/7] hotplug: Fix libvirtd crash on qemu-attached guest

[John Ferlan]

On 10/28/2014 07:54 PM, Michal Privoznik wrote:
> On 09.10.2014 02:08, John Ferlan wrote:
>> v2 is here:
>>
>> http://www.redhat.com/archives/libvir-list/2014-September/msg01575.html
>>
>> As Michal pointed out in his review - other devices could have the
>> same issue - so take care of each of them separately (I already knew
>> the answer to my last question...)
>>
>> Totally different approach this time - rather than error out, follow
>> the example I from the Controller Detach code which will generate an
>> alias for the device (although it did miss one minor check to see if
>> it was already set leading to a potential memory leak since the alias
>> code would overwrite whatever was there).
>>
>> Note: In a way 1/7 was already ACK'd - I just hadn't separated it yet
>> for a push and wanted to keep these closer together when/if they were
>> pushed.
>>
>> Whether 7/7 is now necessary is debateable - I keep it only for
>> completeness and environment setup in much the same way the start
>> code handles aliases.
>>
>> John Ferlan (7):
>>    virsh: Adjust the text in man page regarding qemu-attach
>>    hotplug: Check for alias in controller detach
>>    hotplug: Check for alias in disk detach
>>    hotplug: Check for alias in hostdev detach
>>    hotplug: Check for alias in chrdev detach
>>    hotplug: Check for alias in net detach
>>    qemu-attach: Assign device aliases
>>
>>   src/qemu/qemu_driver.c  |  3 +++
>>   src/qemu/qemu_hotplug.c | 28 +++++++++++++++++++++++++++-
>>   tools/virsh.pod         |  5 +++--
>>   3 files changed, 33 insertions(+), 3 deletions(-)
>>
> 
> ACK
> 
> Michal
> 

Pushed - thanks

John