[libvirt] [PATCH] qemu: make advice from numad available when building commandline

[Michal Privoznik]

On 30.10.2014 07:40, Martin Kletzander wrote:
> Particularly in qemuBuildNumaArgStr(), there was a need for the advice
> due to memory backing, which needs to know the nodeset it will be pinned
> to.  With newer qemu this caused the following error when starting
> domain:
>
>    error: internal error: Advice from numad is needed in case of
>    automatic numa placement
>
> even when starting perfectly valid domain, e.g.:
>
>    ...
>    <vcpu placement='auto'>4</vcpu>
>    <numatune>
>      <memory mode='strict' placement='auto'/>
>    </numatune>
>    <cpu>
>      <numa>
>        <cell id='0' cpus='0' memory='524288'/>
>        <cell id='1' cpus='1' memory='524288'/>
>      </numa>
>    </cpu>
>    ...
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1138545
>
> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>

Would it be possible to add a test case? Maybe you'd need to mock some 
functions but we already have qemuxml2argvmock.c. Otherwise the code 
looks okay and with test case I'd ACK it for the freeze.

Michal