[libvirt] [PATCH] conf: use proper maximum for parsing memory values

Eric Blake eblake at redhat.com
Thu Oct 30 20:01:10 UTC 2014


On 10/30/2014 10:51 AM, Eric Blake wrote:
> On 10/30/2014 10:23 AM, Eric Blake wrote:
>>
>> Or maybe the problem is that at some point we used unsigned long, and
>> later moved to unsigned long long, but never updated the comment?  I'm
>> trying to investigate the history of this code...
> 

> 
> Or maybe the solution is to make virDomainParseMemory add a bool
> parameter that says whether the caller is old-style (32-bit cap) or
> new-style (full 64-bit width), and set the maximum according to that
> information.  That's probably the easiest for doing right now.  I can
> take a stab at it, since it was my commit in 2012 that originally
> introduced the weird 32-bit cap even when parsing a 64-bit field.

I went with this idea:

https://www.redhat.com/archives/libvir-list/2014-October/msg01084.html

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 539 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141030/682c0cc8/attachment-0001.sig>


More information about the libvir-list mailing list