[libvirt] [PATCH 11/26] tests: Resolve Coverity DEADCODE
John Ferlan
jferlan at redhat.com
Thu Sep 4 22:26:19 UTC 2014
Coverity complains that the various checks for autoincrement and changed
variables are DEADCODE - seems to me to be a false positive - so mark it.
Signed-off-by: John Ferlan <jferlan at redhat.com>
---
tests/virstringtest.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/tests/virstringtest.c b/tests/virstringtest.c
index 7c25b22..10fad2c 100644
--- a/tests/virstringtest.c
+++ b/tests/virstringtest.c
@@ -162,10 +162,12 @@ testStrdup(const void *data ATTRIBUTE_UNUSED)
virFilePrintf(stderr, "unexpected strdup result %d, expected 1\n", value);
goto cleanup;
}
+ /* coverity[dead_error_begin] */
if (i != 1) {
virFilePrintf(stderr, "unexpected side effects i=%zu, expected 1\n", i);
goto cleanup;
}
+ /* coverity[dead_error_begin] */
if (j != 1) {
virFilePrintf(stderr, "unexpected side effects j=%zu, expected 1\n", j);
goto cleanup;
@@ -182,14 +184,17 @@ testStrdup(const void *data ATTRIBUTE_UNUSED)
virFilePrintf(stderr, "unexpected strdup result %d, expected 0\n", value);
goto cleanup;
}
+ /* coverity[dead_error_begin] */
if (i != 2) {
virFilePrintf(stderr, "unexpected side effects i=%zu, expected 2\n", i);
goto cleanup;
}
+ /* coverity[dead_error_begin] */
if (j != 2) {
virFilePrintf(stderr, "unexpected side effects j=%zu, expected 2\n", j);
goto cleanup;
}
+ /* coverity[dead_error_begin] */
if (k != 1) {
virFilePrintf(stderr, "unexpected side effects k=%zu, expected 1\n", k);
goto cleanup;
--
1.9.3
More information about the libvir-list
mailing list