[libvirt] [PATCH 1/3] schemas: finish virTristate{Bool, Switch} transition

[Martin Kletzander]

On Mon, Sep 15, 2014 at 09:29:05AM -0600, Eric Blake wrote:
>On 09/15/2014 01:46 AM, Martin Kletzander wrote:
>> On Thu, Sep 11, 2014 at 09:54:51AM -0400, Laine Stump wrote:
>>> On 09/08/2014 07:40 AM, Martin Kletzander wrote:
>>>> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>>>> ---
>
>>>> +        <ref name="virSwitch"/>
>>>
>>> Purely cosmetic, but how about calling them "virYesNo" and "virOnOff" to
>>> avoid confusion? When I see "virBool" I think "true/false", and when I
>>> see "virSwitch" I think "Does this have something to do with a network
>>> device?" :-)
>>>
>>
>> That's another way (and makes more sense).  I just wanted to shorten
>> the "Tristate" since it's not a tristate anyway.  Should I count it as
>> an ACK for s/virSwitch/virOnOff/ and s/virBool/virYesNo/ ?
>
>Yes, I'll agree to that rename.
>

There were more things to be changed, so I sent a completely new
version with this changed:

https://www.redhat.com/archives/libvir-list/2014-September/msg00894.html

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140915/7c04c5ed/attachment-0001.sig>