[libvirt] [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

[Markus Armbruster]

"Michael S. Tsirkin" <mst at redhat.com> writes:

> On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote:
>> Add a configure option --enable-pc-1-0-qemu-kvm and the
>> corresponding --disable-pc-1-0-qemu-kvm, defaulting
>> to disabled.
>> 
>> Rename machine type pc-1.0 to pc-1.0-qemu-git.
>> 
>> Make pc-1.0 machine type an alias of either pc-1.0-qemu-kvm
>> or pc-1.0-qemu-git depending on the value of the config
>> option.
>> 
>> Signed-off-by: Alex Bligh <alex at alex.org.uk>
>
> I have to say, this one bothers me.
> We end up not being able to predict what does pc-1.0
> reference.
>
> Users also don't get qemu from git so I don't see
> why does git make sense in the name?
>
> Legacy management applications invoked qemu as qemu-kvm -
> how about detecting that name and switching
> the machine types?

Ugh!  I like that even less than a configure option.

> It might make sense to also set -enable-kvm and
> change default CPU to kvm64 in this case.

Yup.