[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] tests: nodeinfo: Test F21 aarch64 on APM mustang



On 28.03.2015 19:31, Cole Robinson wrote:
> ---


> diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/subsystem b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/subsystem
> new file mode 120000
> index 0000000..758c291
> --- /dev/null
> +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/subsystem
> @@ -0,0 +1 @@
> +../../../../bus/cpu
> \ No newline at end of file

so this adds a symlink to ../../../../bus/cpu. However, the pointee does not exist:

libvirt.git $ file tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/subsystem 
tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/subsystem: broken symbolic link to ../../../../bus/cpu

But, the file seems to be not needed anyway:

libvirt.git/tests $ ../run strace nodeinfotest 2>&1 | grep subsystem | wc -l
0

I think we should remove it. Oh, and there are some more files like this. Patch on its way.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]