[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [Xen-devel] [PATCH 2/3] libxl: acquire a job when destroying a domain

On Thu, Mar 26, 2015 at 03:29:51PM -0600, Jim Fehlig wrote:
Konrad Rzeszutek Wilk wrote:
On Wed, Mar 25, 2015 at 02:08:35PM -0600, Jim Fehlig wrote:

A job should be acquired at the beginning of a domain destroy operation,
not at the end when cleaning up the domain.  Fix two occurances of this

And s/occurances/occurrences/ here.

It looks fine, though, with the squash-in.

Also, if you want to have a look at some other things that might be
fixed here, plus some speed-up gained, have a look at my commit
540c339a, that does some similar things in the QEMU driver.

late job acquisition in the libxl driver.  Doing so renders
libxlDomainCleanup unused, so it is removed.

Just noticed this should be libxlDomainCleanupJob.

Yes :)

Attachment: pgpQ13rR2JNkj.pgp
Description: PGP signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]