[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] nodeinfodata: Remove broken symlinks



On Wed, Apr 01, 2015 at 11:01:11AM +0200, Michal Privoznik wrote:
The 7c3c7f217ebae5 commit introduced a nodeinfo test. In order to do
that, some parts of sysfs had to be copied. However, sysfs is full of
symlinks, so during copying some symlinks broke. Remove them, as on
different systems they can point to different files or be broken.


That commit introduced only two thirds of the files, the rest is from
f5c2d6 (just in case you want to update the commit message).

But!  Not only we don't need these, but power and uevent don't need to
be there either, do they?  And core_siblings(_list) is also not
something we (will) use since it's just a syntax sugar for parsing
data for all CPUs (that we do anyway).

If you want to clean the test data a bit, I suggest you clean
tests/nodeinfodata/*/cpu/cpu*/{uevent,power,topology/core_siblings*,firmware_node,subsystem}
files too.  That's 202 files you can get rid of.

Attachment: pgppSb4QJH7CT.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]