[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] nodeinfodata: Remove broken symlinks and uneeded files



On 04/01/2015 10:12 AM, Michal Privoznik wrote:
> The 7c3c7f217ebae5 and f5c2d6 commits introduced a nodeinfo test.
> In order to do that, some parts of sysfs had to be copied.
> However, sysfs is full of symlinks, so during copying some
> symlinks broke. Remove them, as on different systems they can
> point to different files or be broken. At the same time, we don't
> need all files added in those commits. For instance we don't care
> about 'uevent' files, 'power' folders, and others.
> 
> Signed-off-by: Michal Privoznik <mprivozn redhat com>

FWIW I just tar'd up the directory. Even if we don't use some of the files
now, IMO it's safer long term to import the dir rather than cherry-pick the
files libvirt currently uses (the broken symlinks are useless though). But
it's not a big deal to me so I'll leave it up to you guys

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]