[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/6] Remove unused macros



On Wed, Apr 01, 2015 at 07:30:22PM +0200, Peter Krempa wrote:
> On Wed, Apr 01, 2015 at 17:32:28 +0200, Ján Tomko wrote:
> > In the order of appearance:
> > 
> > * MAX_LISTEN - never used
> >   added by 23ad665c (qemud) and addec57 (lock daemon)
> > 
> > * NEXT_FREE_CLASS_ID - never used, added by 07d1b6b
> > 
> > * virLockError - never used, added by eb8268a4
> > 
> > * OPENVZ_MAX_ARG, CMDBUF_LEN, CMDOP_LEN
> >   unused since the removal of ADD_ARG_LIT in d8b31306
> > 
> > * QEMU_NB_PER_CPU_STAT_PARAM - unused since 897808e
> > 
> > * QEMU_CMD_PROMPT, QEMU_PASSWD_PROMPT - unused since 1dc10a7
> > 
> > * TEST_MODEL_WORDSIZE - unused since c25c18f7
> > 
> > * TEMPDIR - never used, added by 714bef5
> > 
> > * NSIG - workaround around old headers
> >   added by commit 60ed1d2
> >   unused since virExec was moved by commit 02e8691
> > 
> > * DO_TEST_PARSE - never used, added by 9afa006
> > 
> > * DIFF_MSEC, GETTIMEOFDAY - unused since eee6eb6
> 
> Wow, you bothered with electronic archeology? :)
> 
> > ---
> >  daemon/libvirtd.c               |  1 -
> >  src/conf/network_conf.c         |  1 -
> >  src/locking/lock_daemon.c       |  1 -
> >  src/locking/lock_driver_lockd.c |  4 ----
> >  src/openvz/openvz_driver.c      |  4 ----
> >  src/qemu/qemu_driver.c          |  2 --
> >  src/qemu/qemu_monitor_text.c    |  3 ---
> >  src/test/test_driver.c          |  1 -
> >  src/uml/uml_driver.c            |  3 ---
> >  src/util/virutil.c              |  4 ----
> >  tests/sockettest.c              | 10 ----------
> >  tests/testutils.c               |  5 -----
> >  12 files changed, 39 deletions(-)
> 
> ACK (after the release)

Do we have to explictly state that in the freeze?

I pushed the series now, thanks for the review.

Jan

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]