[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 2/6] iscsi: Fix exit path for virStorageBackendISCSIFindLUs failure



On Wed, Apr 01, 2015 at 01:29:07PM -0400, John Ferlan wrote:
> If the call to virStorageBackendISCSIGetHostNumber failed, we set
> retval = -1, but yet still called virStorageBackendSCSIFindLUs.
> Need to add a goto cleanup - while at it, adjust the logic to
> initialize retval to -1 and only changed to 0 (zero) on success.
> 
> Signed-off-by: John Ferlan <jferlan redhat com>
> ---
>  src/storage/storage_backend_iscsi.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 

ACK

Jan

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]