[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix xlconfigtest with older libxl



Ján Tomko wrote:
> Commit cd5dc30 added this test, but it fails if
> LIBXL_HAVE_BUILDINFO_USBDEVICE_LIST is not defined:
>   

Opps, sorry.  I tested back to Xen 4.3 where I thought this was
undefined.  But looking at that machine now, I see
LIBXL_HAVE_BUILDINFO_USBDEVICE_LIST is defined.  I guess your libxl is
from Xen 4.2?

> 6) Xen XM-2-XML Format fullvirt-multiusb
> ... libvirt:  error : unsupported configuration: multiple USB
> devices not supported
> FAILED
> ---
>  tests/xlconfigtest.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/tests/xlconfigtest.c b/tests/xlconfigtest.c
> index 6d4aa6d..c992548 100644
> --- a/tests/xlconfigtest.c
> +++ b/tests/xlconfigtest.c
> @@ -215,7 +215,10 @@ mymain(void)
>  
>      DO_TEST("new-disk", 3);
>      DO_TEST("spice", 3);
> +
> +#ifdef LIBXL_HAVE_BUILDINFO_USBDEVICE_LIST
>      DO_TEST("fullvirt-multiusb", 3);
> +#endif
>  
>      virObjectUnref(caps);
>      virObjectUnref(xmlopt);
>   

ACK.

Regards,
Jim


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]