[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/6] conf: Introduce virStoragePoolSaveState



> Your previous patch 3/7 had a better commit message:
> 
> Introduce virStoragePoolSaveStatus to properly format the status XML in
> the same manner as virStoragePoolDefFormat, except for adding a
> <poolstatus> ... </poolstatus> around the definition. This is similar to
> virNetworkObjFormat used to save the live/active network information.
> 
>>
>> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1177733
> 
> By itself - no it doesn't solve the bug (same for 4 and 5)
>> ---
>>  src/conf/storage_conf.c  | 35 +++++++++++++++++++++++++++++++++++
>>  src/conf/storage_conf.h  |  4 +++-
>>  src/libvirt_private.syms |  1 +
>>  3 files changed, 39 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
>> index 73b937e..ee564f2 100644
>> --- a/src/conf/storage_conf.c
>> +++ b/src/conf/storage_conf.c
>> @@ -1928,6 +1928,41 @@ static int virStoragePoolSaveXML(const char *path,
>>  
>>      return ret;
>>  }
>> +
>> +
>> +int virStoragePoolSaveState(const char *stateFile,
>> +                            virStoragePoolDefPtr def)
> 
> Again it's
> int
> virStorage...
> 
> 
> ACK with those adjustments.
> 
> John
> 
> FYI: Coverity is happy with all 6 patches...

Thank you, I changed the commit message, fixed the issues and pushed
with Jan's little note in mind (I'll push that one as trivial).

Erik


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]