[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 1/2] conf: ABI: Check WWN in disk abi stability check



Since the WWN influences guest behavior in naming disks we should treat
this as vm ABI.
---
 src/conf/domain_conf.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 1763305..27f29eb 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -15840,6 +15840,14 @@ virDomainDiskDefCheckABIStability(virDomainDiskDefPtr src,
         return false;
     }

+    if (STRNEQ_NULLABLE(src->wwn, dst->wwn)) {
+        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+                       _("Target disk wwn '%s' does not match source '%s'"),
+                       NULLSTR(dst->wwn), NULLSTR(src->wwn));
+        return false;
+
+    }
+
     if (src->src->readonly != dst->src->readonly ||
         src->src->shared != dst->src->shared) {
         virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
-- 
2.2.2


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]