[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 05/11] qemu: blockjob: Split qemuDomainBlockJobSetSpeed from qemuDomainBlockJobImpl




On 04/01/2015 01:20 PM, Peter Krempa wrote:
> qemuDomainBlockJobImpl become an unmaintainable mess over the years of
> adding new stuff to it. This patch starts splitting up individual
> functions from it until it can be killed entirely.
> 
> In bulk this will add lines of code rather than delete them but it will
> be traded for maintainability.
> ---
>  src/qemu/qemu_driver.c       | 66 ++++++++++++++++++++++++++++++++++++--------
>  src/qemu/qemu_monitor.c      | 19 +++++++++++++
>  src/qemu/qemu_monitor.h      |  6 +++-
>  src/qemu/qemu_monitor_json.c | 41 +++++++++++++++++++++------
>  src/qemu/qemu_monitor_json.h |  6 ++++
>  5 files changed, 118 insertions(+), 20 deletions(-)
> 

ACK

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]