[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 07/11] qemu: blockPivot: Don't pause the VM any more since we don't use drive-reopen



On Wed, Apr 08, 2015 at 11:31:18 -0400, John Ferlan wrote:
> 
> 
> On 04/01/2015 01:20 PM, Peter Krempa wrote:
> > Support for drive-reopen was never present in the upstream code so we
> > don't need to pause the VM when doing the block pivot. Kill all the
> > code related to this semi-upstream artifact.
> > ---
> >  src/qemu/qemu_driver.c | 48 +++++-------------------------------------------
> >  1 file changed, 5 insertions(+), 43 deletions(-)
> > 
> 
> ACK - although it seems to be outside the realm of .0 "Refactor the
> block job code"...  IOW - should this have been a separate patch.

Separate as in a separate series? .. well it fixes block job code so I
think it belongs in this series.

I've pushed patches 2,3,4,6 and 7 and will follow up with the rest in
V3.

Thanks for the review.

Peter

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]