[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 5/5] qemu: qemuDomainHotplugVcpus - separate out pin adjustment code



On Wed, Apr 08, 2015 at 09:50:43AM -0400, John Ferlan wrote:
> Future IOThread setting patches would copy the code anyway, so create
> and generalize the adding of pindef for the vcpu and the pinning of the
> thread into their own APIs.
> 
> Signed-off-by: John Ferlan <jferlan redhat com>
> ---
>  src/qemu/qemu_driver.c | 103 ++++++++++++++++++++++++++++++++-----------------
>  1 file changed, 67 insertions(+), 36 deletions(-)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 7810dee..4165e9e 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -4670,6 +4670,67 @@ qemuDomainAddCgroupForThread(virCgroupPtr cgroup,
>  }
>  
>  static int
> +qemuDomainHotplugAddPin(virBitmapPtr cpumask,
> +                        int index,
> +                        virDomainPinDefPtr **pindef_list,
> +                        size_t *npin)
> +{
> +    int ret = -1;
> +    virDomainPinDefPtr pindef = NULL;
> +
> +    /* vm->def->cputune.* arrays can't be NULL if
> +     * vm->def->cpumask is not NULL.
> +     */


ACK with this comment removed.

Jan

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]