[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 2/9] Convert virDomainPinIsDuplicate into bool return




On 04/13/2015 06:33 AM, Peter Krempa wrote:
> On Fri, Apr 10, 2015 at 17:36:20 -0400, John Ferlan wrote:
>> Signed-off-by: John Ferlan <jferlan redhat com>
>> ---
>>  src/conf/domain_conf.c | 8 ++++----
>>  src/conf/domain_conf.h | 6 +++---
>>  2 files changed, 7 insertions(+), 7 deletions(-)
> 
> ACK, by the way, the function is exported, but is used only in
> conf/domain_conf.c thus it could be converted to static.
> 
> Peter
> 

OK - I've separated these first two out, but since
virDomainPinIsDuplicate is defined after it's used - I think it would be
worthy of a separate patch "later" (I have it on my short list) to make
it local and of course move it...

Unless of course you want to do that in the series you have on list
right now dealing with the PinParser...

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]