[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/5] conf: Refactor virDomainVcpuPinDefParseXML




On 04/07/2015 02:50 PM, Peter Krempa wrote:
> Refactor the code to parse the vcpupin in a similar way the iothreadpin
> code is now structured. This allows to get rid of some very strange
> conditions and error messages.
> 
> Additionally since a existing bug
> ( https://bugzilla.redhat.com/show_bug.cgi?id=1208434 ) allows to add
> vcpupin definitions for vcpus that don't exist, this patch makes the
> parser to ignore all vcpupins that don't have a matching vCPU in the
> definition rather than just offlined ones.
> ---
>  src/conf/domain_conf.c | 33 ++++++++++++---------------------
>  1 file changed, 12 insertions(+), 21 deletions(-)
> 

Hmm - oh I see...  The deleted vcpuid >= maxvcpus check disappearing was
the cause of the above mentioned bug... and of course there's a
duplicated check later on...

ACK,

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]