[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/5] qemu: add QEMU_CAPS_MACHINE_VMPORT_OPT



On 04/14/2015 10:24 AM, Martin Kletzander wrote:

>>
>> That works with the following change:
>>
> 
> ACK with that squashed in, no need to resend it ;)
> 
>> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
>> index 768cef1..1b20a7f 100644
>> --- a/src/qemu/qemu_capabilities.c
>> +++ b/src/qemu/qemu_capabilities.c
>> @@ -2510,6 +2510,7 @@ struct virQEMUCapsCommandLineProps {
>>
>> static struct virQEMUCapsCommandLineProps virQEMUCapsCommandLine[] = {
>>     { "machine", "mem-merge", QEMU_CAPS_MEM_MERGE },
>> +    { "machine", "vmport", QEMU_CAPS_MACHINE_VMPORT_OPT },

But this will break on qemu 2.3, unless something changes there.  I
don't want to do a version check, but I also don't want something that
works by accident in qemu 2.2 start failing with qemu 2.3.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]