[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: save domain status after set memory parameters




On 04/14/2015 07:54 PM, Ján Tomko wrote:
> On Tue, Apr 14, 2015 at 06:24:41PM +0800, Shanzhi Yu wrote:
>> After set memory parameters for running domain, save the change to live
>> xml is needed otherwise it will disappear after restart libvirtd.
>>
>> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1211548
>> Signed-off-by: Shanzhi Yu <shyu redhat com>
>> ---
>>  src/qemu/qemu_driver.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
>> index e790664..2e4504e 100644
>> --- a/src/qemu/qemu_driver.c
>> +++ b/src/qemu/qemu_driver.c
>> @@ -9843,6 +9843,9 @@ qemuDomainSetMemoryParameters(virDomainPtr dom,
>>  
>>  #undef QEMU_SET_MEM_PARAMETER
>>  
>> +    if (virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm) < 0)
>> +        goto endjob;
> This should only be done if flags & VIR_DOMAIN_AFFECT_LIVE.
>
> ACK and pushed with that change.

Oh, right.
Thanks for your review for both.

>
> Jan

-- 
Regards
shyu


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]