[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/5] Link libvirt_util with datatypes



On Mon, Apr 13, 2015 at 16:33:49 +0200, Martin Kletzander wrote:
> We were lucky enough for this to work because the datatypes files were
> linked to in the resulting binary, but the dependency really is already
> in libvirt_util.
> 
> Signed-off-by: Martin Kletzander <mkletzan redhat com>
> ---
>  src/Makefile.am | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 91a4c17..8c26076 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -1,6 +1,6 @@
>  ## Process this file with automake to produce Makefile.in
> 
> -## Copyright (C) 2005-2014 Red Hat, Inc.
> +## Copyright (C) 2005-2015 Red Hat, Inc.
>  ##
>  ## This library is free software; you can redistribute it and/or
>  ## modify it under the terms of the GNU Lesser General Public
> @@ -86,9 +86,12 @@ augeas_DATA =
>  augeastestdir = $(datadir)/augeas/lenses/tests
>  augeastest_DATA =
> 
> +DATATYPES_SOURCES = datatypes.h datatypes.c
> +
>  # These files are not related to driver APIs. Simply generic
>  # helper APIs for various purposes
>  UTIL_SOURCES =							\
> +		$(DATATYPES_SOURCES)				\
>  		util/viralloc.c util/viralloc.h			\
>  		util/virarch.h util/virarch.c			\
>  		util/viratomic.h util/viratomic.c		\

I think this makes it wrong the other way. While they are used in the
utils they definitely are not just 'utils'. The source file contains
definitions and declarations for the public data types and that
definitely is not "just utils". Btw, read the comment right above the
UTIL_SOURCES line ...

The real problem here is that 'util' uses types from the datatypes file.

Do you know of any examples that make utils depend on datatypes.h?

Peter

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]