[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 6/7] qemu: monitor: Fix qemuMonitorGetAllBlockStatsInfo with HMP



On Tue, Apr 14, 2015 at 18:05:10 +0200, Peter Krempa wrote:
> Commit f6563bc3 introduced HMP impl of the function (so that a different
> uglier function could be removed). Before the HMP code is called there's
> a leftover check that the monitor is JSON which inhibits the code from
> working.
> ---
>  src/qemu/qemu_monitor.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
> index 20605cd..d5bdfb8 100644
> --- a/src/qemu/qemu_monitor.c
> +++ b/src/qemu/qemu_monitor.c
> @@ -1873,12 +1873,6 @@ qemuMonitorGetAllBlockStatsInfo(qemuMonitorPtr mon,
>      int ret = -1;
>      VIR_DEBUG("mon=%p ret_stats=%p, backing=%d", mon, ret_stats, backingChain);
> 
> -    if (!mon->json) {
> -        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
> -                       _("unable to query all block stats with this QEMU"));
> -        return -1;
> -    }
> -
>      if (!(*ret_stats = virHashCreate(10, virHashValueFree)))
>          goto error;

ACK

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]