[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 3/5] Strip control characters from sysfs attributes



On Tue, Apr 14, 2015 at 13:28:48 +0200, Ján Tomko wrote:
> Including them in the XML makes them unparsable.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1184131
> ---
>  src/node_device/node_device_udev.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c
> index 8c39e5f..5e98222 100644
> --- a/src/node_device/node_device_udev.c
> +++ b/src/node_device/node_device_udev.c
> @@ -239,6 +239,8 @@ static int udevGetStringSysfsAttr(struct udev_device *udev_device,
>  
>      ret = udevGetDeviceSysfsAttr(udev_device, attr_name, &tmp);
>  
> +    virStringStripControlChars(tmp);
> +

Looks safe enoguh to me, but I'd state in a comment that this function
strips possible control chars.

>      if (tmp != NULL && (STREQ(tmp, ""))) {
>          VIR_FREE(tmp);
>          tmp = NULL;

ACK with comment added.

Peter

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]