[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] node: udev: Remove some redundant error reports



On Wed, Apr 15, 2015 at 02:54:12PM +0200, Peter Krempa wrote:
All the called functions already report an error.
---
src/node_device/node_device_udev.c | 15 ++-------------
1 file changed, 2 insertions(+), 13 deletions(-)

diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c
index 8c39e5f..1025e80 100644
--- a/src/node_device/node_device_udev.c
+++ b/src/node_device/node_device_udev.c
@@ -213,9 +210,6 @@ static int udevGetDeviceSysfsAttr(struct udev_device *udev_device,
    /* If this allocation is changed, the comment at the beginning
     * of the function must also be changed. */
    if (VIR_STRDUP(*attr_value, udev_value) < 0) {
-        VIR_ERROR(_("Failed to allocate memory for sysfs attribute value for "
-                    "sysfs attribute '%s' on device with sysname '%s'"),
-                  attr_name, udev_device_get_sysname(udev_device));

Even though this might help in debugging if it were a VIR_DEBUG, it
doesn't make much sense since that happens only on OOM, so ACK.

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]