[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] daemon: Prefix sysctl configuration file with numbers



On Thu, Apr 16, 2015 at 06:45:44 -0600, Eric Blake wrote:
> On 04/15/2015 05:12 AM, Jiri Denemark wrote:
> > Apparently, files in /usr/lib/sysctl.d are usually prefixed with numbers
> > for easier ordering. Let's be consistent with this. I chose 60 for
> > libvirtd so that it goes after 50-default.conf.
> > 
> > https://bugzilla.redhat.com/show_bug.cgi?id=1084876
> > Signed-off-by: Jiri Denemark <jdenemar redhat com>
> > ---
> > 
> > Notes:
> >     Actually, %config(noreplace) for a file in /usr/lib/sysctl.d looks
> >     somewhat wrong to me and I think we should fix that too. After all
> >     the files are usually placed in /usr/lib because they are not
> >     supposed to be modified by administrators. They should be able to
> >     override the settings in /etc/. Any opinion about this?
> 
> I think the idea of allowing overrides from /etc makes sense - but do we
> actually parse up to two files, with the last parse winning?  If not,
> that's more code to add first.

I haven't checked, since "we" is the service running sysctl on boot
rather than libvirt. I was hoping someone would just know how it works.
I'll try to investigate.

Anyway, I pushed the patch without touching the config(noreplace) part.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]