[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 2/4] refactor virStorageBackendSCSINewLun




On 04/16/2015 08:35 AM, Ján Tomko wrote:
> On Tue, Apr 07, 2015 at 04:21:01PM -0400, John Ferlan wrote:
> 
> This could use some comment about inverting the logic of the retval
> variable.
> 
>> Signed-off-by: John Ferlan <jferlan redhat com>
>> ---
>>  src/storage/storage_backend_scsi.c | 55 ++++++++++++++------------------------
>>  1 file changed, 20 insertions(+), 35 deletions(-)
>>
> 
> ACK
> 
> Jan
> 

Weird - usually my verbosity gets flagged as being too much, but not
like me to have no commit message...

In any case, adjusted commit message and pushed. Working through other
comments and will post a v4 later today.

Tks

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]