[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [Xen-devel] [PATCH] libxl: initialize vfb defbools in libxlMakeVfb



On Mon, 2015-04-20 at 12:32 +0200, Olaf Hering wrote:
> On Mon, Apr 20, Ian Campbell wrote:
> 
> > It makes no sense to do that at init time, the whole purpose of a
> > defbool is to allow the calling application to choose a value or to
> > explicitly leave it as a request to for the default (which might vary
> > depending on other selections).
> 
> Yes, and thats why my patch does?

This is a libvirt patch. It might be correct in its own right, if
libvirt has different ideas about the defaults to libxl, but it is also
masking an underlying libxl bug.

Ian.

> 
>  libxl_device_vfb_init(x_vfb);
> +libxl_defbool_set(&x_vfb->sdl.opengl, 0);
>  if (libxl_defbool_val(vfb.sdl.opengl))
>    ;
> 
> Olaf



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]