[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 1/2] virDomainActualNetDefContentsFormat: Format class_id only for status XML



On 04/21/2015 08:22 AM, Michal Privoznik wrote:
> In one of my previous patches (b68a56bcfe) I made class_id to
> format more frequently. Well, now it's formatting way too
> frequent - even for regular active XML. Users don't need to see
> it, so lets format it only for the status XML where it's really
> needed.
>
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  src/conf/domain_conf.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 479b4c2..9aad782 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -18522,7 +18522,8 @@ virDomainActualNetDefContentsFormat(virBufferPtr buf,
>  
>          virBufferAddLit(buf, "/>\n");
>      }
> -    if (def->data.network.actual && def->data.network.actual->class_id) {
> +    if (flags & VIR_DOMAIN_DEF_FORMAT_STATUS &&
> +        def->data.network.actual && def->data.network.actual->class_id) {
>          virBufferAsprintf(buf, "<class id='%u'/>\n",
>                            def->data.network.actual->class_id);
>      }

ACK.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]