[libvirt] [PATCH 03/11] caps: Use an enum internally for ostype value
Cole Robinson
crobinso at redhat.com
Tue Apr 21 20:18:52 UTC 2015
On 04/21/2015 05:22 AM, Christophe Fergeau wrote:
> Hey,
>
> On Fri, Apr 17, 2015 at 09:45:13PM -0400, Cole Robinson wrote:
>> +VIR_ENUM_IMPL(virDomainOS, VIR_DOMAIN_OSTYPE_LAST,
>> + "hvm",
>> + "xen",
>> + "linux",
>> + "exe",
>> + "uml",
>> + "aix")
>> +
>
> This is preexisting before your patch, but is more obvious now.
> Shouldn't 'aix' be listed in docs/schemas/capability.rng? Currently it's
>
> <define name='ostype'>
> <element name='os_type'>
> <choice>
> <value>xen</value> <!-- Xen 3.0 pv -->
> <value>linux</value> <!-- same as 'xen' - legacy -->
> <value>hvm</value> <!-- unmodified OS -->
> <value>exe</value> <!-- For container based virt -->
> <value>uml</value> <!-- user mode linux -->
> </choice>
> </element>
> </define>
>
> Christophe
>
Good point, I just sent a patch
Thanks,
Cole
More information about the libvir-list
mailing list