[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] lxc: don't up the veth interfaces unless explicitly asked to



On Wed, Apr 22, 2015 at 05:02:49PM +0200, Lubomir Rintel wrote:
> Upping an interface for no reason and not configuring it is a cardinal sin.

The interface may well be configured with both IPv4 & IPv6 addresses
depending on the XML config for the guest....


> diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c
> index cc20b6d..50e38e9 100644
> --- a/src/lxc/lxc_container.c
> +++ b/src/lxc/lxc_container.c
> @@ -541,7 +541,7 @@ static int lxcContainerRenameAndEnableInterfaces(virDomainDefPtr vmDef,
>              VIR_FREE(ipStr);
>          }
>  
> -        if (netDef->linkstate != VIR_DOMAIN_NET_INTERFACE_LINK_STATE_DOWN) {
> +        if (netDef->linkstate == VIR_DOMAIN_NET_INTERFACE_LINK_STATE_UP) {

...so this is wrong because it doesn't take account of the fact that we may
have configured addresses just a few lines earlier in this very same function

I'm fine with not setting the link state to online, but *only* if we do not
have any addresses configured in the XML for that NIC.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]