[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 0/6] Add vmport feature



ping

On Tue, Apr 21, 2015 at 1:57 PM, Marc-André Lureau <marcandre lureau gmail com> wrote:
Hi,

The QEMU machine vmport option allows to set the VMWare IO port
emulation. This emulation is useful for absolute pointer input when the
guest has vmware input drivers, and is enabled by default for kvm.

However it is unnecessary for Spice-enabled VM, since the agent already
handles absolute pointer and multi-monitors. Furthermore, it prevents
Spice from switching to relative input since the regular ps/2 pointer
driver is replaced by the vmware driver. It is thus advised to disable
vmport when using a Spice VM. This will permit the Spice client to
switch from absolute to relative pointer, as it may be required for
certain games or applications.

The following patch series allows to configure the vmport feature.

v2:
 - use a feature instead of a domain attribute, suggested by D. Berrange
v3:
 - use qmp query for caps instead of version
v4:
 - use vesion check & qmp, add runtime check for machine kind

Marc-André Lureau (6):
  docs: add domain vmport feature
  domain/conf: add VIR_DOMAIN_FEATURE_VMPORT
  qemu: add QEMU_CAPS_MACHINE_VMPORT_OPT
  qemu: add virQEMUCapsSupportsVmport
  qemu: add machine vmport argument
  tests: add machine-vmport-opt qemu test

 docs/formatdomain.html.in                          |  6 ++++
 docs/schemas/domaincommon.rng                      |  9 ++++++
 src/conf/domain_conf.c                             |  5 +++-
 src/conf/domain_conf.h                             |  1 +
 src/qemu/qemu_capabilities.c                       | 20 +++++++++++++
 src/qemu/qemu_capabilities.h                       |  4 +++
 src/qemu/qemu_command.c                            | 33 +++++++++-------------
 src/qemu/qemu_domain.c                             | 19 +++++++++++++
 src/qemu/qemu_domain.h                             |  3 ++
 .../qemuxml2argv-machine-vmport-opt.args           |  6 ++++
 .../qemuxml2argv-machine-vmport-opt.xml            | 28 ++++++++++++++++++
 tests/qemuxml2argvtest.c                           |  2 ++
 12 files changed, 116 insertions(+), 20 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-vmport-opt.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-vmport-opt.xml

--
2.1.0




--
Marc-André Lureau

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]