[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [Xen-devel] [PATCH] libxl: initialize vfb defbools in libxlMakeVfb



Olaf Hering wrote:
> On Fri, Apr 17, Jim Fehlig wrote:
>
>   
>> On 04/17/2015 11:19 AM, Olaf Hering wrote:
>>     
>>> +            libxl_defbool_set(&x_vfb->vnc.enable, 0);
>>>       
>> Not shown here, but just before the switch is
>>
>>      libxl_device_vfb_init(x_vfb);
>>
>> which IIUC (looking at the impl in $xensrc/tools/libxl/_libxl_types.c)
>> should initialize the vfb struct with default values.
>>     
>
> Yes, but the default values lead to the assert.
>   

Ok, best to be a bit defensive.  I've pushed the patch now.

Regards,
Jim


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]