[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] typo: fix typo error in virLXCControllerSetupResourceLimits



On Sat, Apr 25, 2015 at 02:10:00PM +0800, zhang bo wrote:
> iff -> if

Michal insists that iff is a real word meaning 'if and only if':
http://en.wiktionary.org/wiki/iff
So we shouldn't correct it as a typo.

> rather then -> rather than
> 
> Signed-off-by: YueWenyuan <yuewenyuan huawei com>
> ---
>  src/lxc/lxc_controller.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c
> index e144c2d..7ad9d50 100644
> --- a/src/lxc/lxc_controller.c
> +++ b/src/lxc/lxc_controller.c
> @@ -745,9 +745,9 @@ static int virLXCControllerSetupResourceLimits(virLXCControllerPtr ctrl)
>  
>      if (mode == VIR_DOMAIN_NUMATUNE_MEM_STRICT &&
>          virCgroupControllerAvailable(VIR_CGROUP_CONTROLLER_CPUSET)) {
> -        /* Use virNuma* API iff necessary. Once set and child is exec()-ed,
> +        /* Use virNuma* API if necessary. Once set and child is exec()-ed,
>           * there's no way for us to change it. Rely on cgroups (if available
> -         * and enabled in the config) rather then virNuma*. */
> +         * and enabled in the config) rather than virNuma*. */

This was copied from a similar code in qemuProcessHook that has the same
typo.

>          VIR_DEBUG("Relying on CGroups for memory binding");
>      } else {
>  

ACK, I have removed the iff->if change and fixed 'then' in qemu_process
as well before pushing the patch.

Jan

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]