[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Add missing linker flags for MinGW build



On Mon, Apr 27, 2015 at 05:40:28PM +0300, Pavel Fedin wrote:
Hello!

Thirdly, I wonder why you needed to add this, is gnulib really needed?
is that because of those strdup()s in the file?  Why doesn't it fail
with gcc then?

Fourthly (is that even a word?), I'd ACK this and push it, but just
please let me know whether GNULIB_LIBS is really needed here, so I know
if I need to amend this or not.

Yes, it is. Without GNULIB i get "undefined symbol" on... rtl_something...
Sorry, don't remember, but this clearly belongs to gnulib.
On Linux .so module can contain undefined symbols, which will be picked up
from surrounding binaries; on Windows it cannot. Hence this little problem.


I already saw that with one build using MinGW (unfortunately I'm
currently unable to use mingw compiler on my machine), so I sent
another patch for that, added your SoB, but added it to LDADD instead
of LDFLAGS as that's the right place to use it.

If it works, feel free to close the BZ or reply if it doesn't.

Have a nice day,
Martin

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]