[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/2] conf: Resolve some Coverity errors



On Mon, Apr 27, 2015 at 15:08:42 -0400, John Ferlan wrote:
> Resolve some Coverity errors with IOThread changes
> 
> Signed-off-by: John Ferlan <jferlan redhat com>
> ---
> 
> I ran my Coverity checker too, but I looked at the wrong results
> tab when I went to check the results... I looked at a previous run
> which was clean, not the most recent run which wasn't.  Doing
> multiple compiles in separate tabs and just couldn't keep it all
> straight (<sigh> - old age I guess)
> 
>  src/conf/domain_conf.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 0b18720..fc48ed5 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -13253,6 +13253,7 @@ virDomainIOThreadIDDefParseXML(xmlNodePtr node,
>  
>   error:
>      virDomainIOThreadIDDefFree(iothrid);
> +    iothrid = NULL;
>      goto cleanup;
>  }
>  
> @@ -13342,7 +13343,7 @@ virDomainIOThreadPinDefParseXML(xmlNodePtr node,
>  {
>      int ret = -1;
>      virDomainIOThreadIDDefPtr iothrid;
> -    virBitmapPtr cpumask;
> +    virBitmapPtr cpumask = NULL;
>      xmlNodePtr oldnode = ctxt->node;
>      unsigned int iothreadid;
>      char *tmp = NULL;

I've already ACKed Roman's patch that fixes this.

> @@ -13372,6 +13373,7 @@ virDomainIOThreadPinDefParseXML(xmlNodePtr node,
>          virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
>                         _("Cannot find 'iothread' : %u"),
>                         iothreadid);
> +        goto cleanup;
>      }
>  
>      if (!(tmp = virXMLPropString(node, "cpuset"))) {

ACK,

Peter

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]