[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] numa: Rewrite virNumaGetNodeCPUs() to query CPUs dynamically.



On Wed, Apr 29, 2015 at 09:53:31AM +0200, Andrea Bolognani wrote:
> numa_node_to_cpus() uses an internal cache to store the mapping
> between NUMA nodes and CPUs (see Bug #1213835), which means
> long-running processes such as libvirtd will get stale data if
> CPU hotplugging is used during their lifetime.
> 
> The function has been rewritten to collect the information
> directly from sysfs.
> ---
>  src/util/virnuma.c | 158 +++++++++++++++++++++++++++--------------------------
>  1 file changed, 81 insertions(+), 77 deletions(-)

It seems to me that every application that uses libnuma is going to
potentially suffer from the same problem. As such I don't think it
is a good use of effort to workaround it in libvirt - it should be
fixed in libnuma itself, so every applications benefits from the
fix.

So, NACK to this.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]